Feature Contribution Help!

[salahineo]

Hi Everyone,

I’m Mohamed Salah. Frontend Developer.
I really love this application with its amazing features, but unfortunately, I didn’t found the dark mode feature ready yet.

So I decided to help (by the experience of my job) and make a CSS file that overrides the web app theme to be dark,
Then I've added the functionality to let users change the theme from settings and save this change to localStorage.

Here are screenshots for settings select menu which users can change application theme from it:

Here are screenshots for the dark mode view:

Now I've only one issue,
That is my first time to contribute to an open source project, so I don't know the required steps for this contribution.

Step I followed to implement this feature:

1. Clone the Web-UI repository
2. Create a new branch called dev/dark-theme
3. Implement feature by adding new files and writing some codes
4. Commit my changes to this local branch
5. [Issue Here] There is a permission error while publishing my local branch or pushing changes to remote repo

I don't know if this is the correct approach of contributing to this project, but it is the approach I used when working on my company projects.

So can anyone help me how to push my changes to this repo and create a new release with this feature.
Thanks.

[ErikBjare]

Hi Mohamed, changes look great!

To contribute a PR, you first need to fork the repo (using the leftmost button in the top-right corner):

Once you've forked the repo, you can change the remote of your branch using git remote set-url <url to your forked repo>, and then push as normal. Once you've pushed to your own branch, you can open a PR with the changes!

[salahineo]

Thank you,
I've opened a PR for this feature now.

[peepo5]

I see you say you opened a PR but I searched by your account name and nothing comes up?

[salahineo]

@peepopoggers
Here is the pull request URL:
ActivityWatch/aw-webui#307

[JFMugen]

That looks awesome. Just wanted to say to @salahineo, you could/can use Dark Reader extension as well. Not just for AW, for pretty much everything. (only thing it didn't work was my modem interface so far)

If you are like me who use EVERYTHING with dark mode, then it is a godsend ^^

[salahineo]

Thanks, it is really helpful 👍