Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Allow hiding password length #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow hiding password length #482

wants to merge 1 commit into from

Conversation

szh
Copy link

@szh szh commented Apr 3, 2023

Addresses comments to #386

This PR allows you to set the HideCharacter to a space which will be interpreted by the RuneReader to mean that the user input should not be echoed and that it shouldn't print a "mask" either.

@AlecAivazis
Copy link
Owner

AlecAivazis commented May 4, 2023

This looks good - mind adding a test case to this file?

@szh
Copy link
Author

szh commented May 4, 2023

This looks good - mind adding a test case to this file?

I don't see how to add a test case there since the prompt is the same. I think this would require some refactoring. Do you want me to attempt?

@szh
Copy link
Author

szh commented Jun 23, 2023

@AlecAivazis can we get this moving?

@AlecAivazis
Copy link
Owner

Yea feel free to refactor the tests to verify this behavior

@AlecAivazis AlecAivazis reopened this Jun 23, 2023
@AlecAivazis
Copy link
Owner

Whoops! Wrong button 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants