Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5 Feedback #22

Open
12 of 17 tasks
AlfieJones opened this issue Mar 13, 2023 · 0 comments
Open
12 of 17 tasks

V5 Feedback #22

AlfieJones opened this issue Mar 13, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@AlfieJones
Copy link
Owner

AlfieJones commented Mar 13, 2023 •
edited
Loading

v5

Introduction

Version 5 is close to complete and so any community feedback will be greatly welcomed.

Checkout the current toggles https://63c6ef3f3a92fe99f4ff4386-gjfzipvoqj.chromatic.com

Main Changes

Everything

  • - package renaming: theme-toggles now becomes @theme-toggles/core
  • - Refactored build pipelines
  • - Moving doc/website into this mono repo
  • - Rewriting docs with nextra
  • - Added storybook for toggle development
  • - Redesigning all toggles to be clearer in smaller sizes
  • - Redesigning 'unclear' toggles e.g. eclipse
  • - Finish docs
  • - Create a release pipeline
  • - Change prefers-reduced-motion media query to no-preference #19

@theme-toggles/core

  • - Ability to toggle the toggles via .dark classes (makes integration with tailwind very simple) The current method still works and overrides this behaviour
  • - Improved accessibility (more feedback is greatly welcomed)
  • - Added outlines to checkbox/button
  • - Checkbox keyboard interactions are working

@theme-toggles/react

  • - Removed internal state handling
  • - The toggle will respond to the global .dark class
  • - The toggle accepts a toggled boolean which overrides the .dark behaviour
@AlfieJones AlfieJones added enhancement New feature or request help wanted Extra attention is needed labels Mar 13, 2023
@AlfieJones AlfieJones mentioned this issue Mar 13, 2023
Closed
@AlfieJones AlfieJones pinned this issue Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlfieJones