Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Comparison tests to Catlab > v0.16.9 #175

Open
lukem12345 opened this issue Jul 12, 2024 · 1 comment
Open

Update Comparison tests to Catlab > v0.16.9 #175

lukem12345 opened this issue Jul 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lukem12345
Copy link
Member

Comparison tests in test/ModelComparison.jl pass on Catlab v0.16.9 but fail on later versions.

I am not sure what the intention of these tests is, but note that by changing line 32 in test/ModelComparison.jl from

so = Subobject.(legs(c_res))

to

so = Subobject.(feet(c_res))

, all following logical tests pass save for:

¬(A  B) != ¬(A)  B

and

implies((AB), A) == AB

Those tests further pass if == and != are substituted in respectively.

@lukem12345 lukem12345 added the bug Something isn't working label Jul 12, 2024
@kris-brown kris-brown self-assigned this Jul 12, 2024
@kris-brown
Copy link

I'll look into this! Seems caused by AlgebraicJulia/Catlab.jl#909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants