-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance docu about _upsertBindings() #180
Comments
Ah, difficult to believe this hasn't come up before. I thought we handled this case? Checkout _setRender. When you extend the view, we wrap it, call your new render, and do some other work. We could probably find a way in there to do the upsert in there and make you never have to worry about it. What do you think? |
@cdaringe this sounds good and looks like the right place, the same would be for |
I've had many issues with bindings in Ampersand. I've actually kind of just started writing my own bindings manually. |
I believe once this PR is merged it will solve this issue #181 |
After #105 has been successfully solved it is necessary to call
this._upsertBindings()
in therender
function. Otherwise the view won't be rendered correctly after it has been removed. This happens mostly if you use a ampersand-view-switcher to handle your workflow and you have overridden therender
function to do your own stuff. A better solution would be to generally callthis._upsertBindings()
, whenrender()
is called, even if it is overridden.The text was updated successfully, but these errors were encountered: