Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-lock.json #200

Open
RickButler opened this issue Jun 6, 2018 · 1 comment
Open

package-lock.json #200

RickButler opened this issue Jun 6, 2018 · 1 comment

Comments

@RickButler
Copy link
Collaborator

RickButler commented Jun 6, 2018

I was going to do a minor patch for the memory leak in _subviews, and I have npm@latest (6.1.0) and ran npm install and it overwrote the package-lock.json. It seems like they have made a lot of changes between certain NPM versions. For some context and history see this stackoverflow

I was thinking we should either always use @lastest or we should be using the newest version released as part of Node LTS. I lean toward @latest just because I would like to integrate NPM Audit, take a look at #201.

@dhritzkiv, I know you have been dealing with releasing package-lock.json for most repositories, I'm going to test if my changes are compatible with older versions, if not I will revert my change.

We might also consider adding engines to package.json with our recommended version of NPM.

@dhritzkiv
Copy link
Member

Yeah, using latest/latest LTS is a good idea.

Also, I wouldn't worry too much about overwriting the package-lock.json file. I've had no issues between differences in package-lock file across versions of npm, on any of my repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants