Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feed.json when there are multiple screenshots #2721

Open
prateekmedia opened this issue Sep 5, 2021 · 7 comments
Open

Fix feed.json when there are multiple screenshots #2721

prateekmedia opened this issue Sep 5, 2021 · 7 comments

Comments

@prateekmedia
Copy link
Contributor

Let's say I want AppImage Pool app screenshot's, now the problem is that I have added 4 screenshot in appdata xml but appimagehub's feed.json shows 1, it is for all appimage in feed.json.

Can you add code to fetch all screenshots instead of only one?

@probonopd
Copy link
Member

probonopd commented Sep 5, 2021

The AppStream spec is from
https://freedesktop.org/software/appstream/docs/chap-Quickstart.html#qsr-app-screenshots-info
so it is not from the AppImage developers.

For appimage.github.io we are currently using only one screenshot.

@prateekmedia
Copy link
Contributor Author

@probonopd Yeah I wanted to focus on the second sentence, if an app has more screenshot then how we can use it, Like I want to use it in my AppImage Pool app store.

Can you help me generate a custom feed.json that has it, or how are you fetching posts in feed.json file https://github.com/AppImage/appimage.github.io/blob/master/feed.json

@probonopd
Copy link
Member

probonopd commented Sep 5, 2021

https://appimage.github.io/feed.json already contains them:

        {
        "name": "AppImagePool",
    
        "description": "<p>Simple AppImageHub Client</p>\n<p>Top Features:</p>\n<ul>\n  <li>FLOSS and non profit app</li>\n  <li>Simple categories</li>\n  <li>Download from github directly, no extra-server involved</li>\n  <li>Upgrade and Downgrade appimages easily</li>\n  <li>Version History and multi download support</li>\n  <li>Fast downloader</li>\n</ul>\n<p>Note : Some features are not implemented yet.</p>",
    
        "categories": ["Utility"],
        "authors" : [{"name":"prateekmedia","url":"https://github.com/prateekmedia"}],
        "license" : "GPL-3.0-only",
        "links": [{"type":"GitHub","url":"prateekmedia/appimagepool"},{"type":"Download","url":"https://github.com/prateekmedia/appimagepool/releases"}],
        "icons": ["AppImagePool/icons/scalable/appimagepool.svg"],
        "screenshots" : ["https://github.com/prateekmedia/appimagepool/blob/main/assets/screenshot/home.jpg?raw=true
https://github.com/prateekmedia/appimagepool/blob/main/assets/screenshot/category.jpg?raw=true
https://github.com/prateekmedia/appimagepool/blob/main/assets/screenshot/app.jpg?raw=true
https://github.com/prateekmedia/appimagepool/blob/main/assets/screenshot/search.jpg?raw=true"]
        },

but indeed it looks like they are just concatenated together without spaces between them?

@probonopd probonopd reopened this Sep 5, 2021
@prateekmedia
Copy link
Contributor Author

prateekmedia commented Sep 5, 2021

@probonopd Oh sorry and thanks, can you tell me from where are you fetching posts in feed.json.

@probonopd
Copy link
Member

probonopd commented Sep 5, 2021

Jekyll generates the feed using https://github.com/AppImage/appimage.github.io/blob/81ce3b56a988f1b1185f138cb2fc3f96ce030f6f/feed.json.

Do you know how to change

"screenshots" : {{ post.screenshots | jsonify }}

so that the different screenshots do not simply get concatenated? Jekyll jsonify doesn't seem to do the right thing here?

@prateekmedia
Copy link
Contributor Author

Yeah they don't have commas between them and are concatenated together.

@probonopd probonopd changed the title If all posts contain one screenshot, so why is it named screenshots Fix feed.json when there are multiple screenshots Sep 5, 2021
@prateekmedia
Copy link
Contributor Author

Do you know how to change

Sadly I am no expert in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants