Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Use included screenshot #3350

Open
Drsheppard01 opened this issue Jun 7, 2024 · 3 comments
Open

[Feature Request] Use included screenshot #3350

Drsheppard01 opened this issue Jun 7, 2024 · 3 comments

Comments

@Drsheppard01
Copy link
Contributor

Drsheppard01 commented Jun 7, 2024

I think the best UX is to use the screenshot specified in appdata.metainfo. I even wrote a small parser (I managed to get the right result, but I'm sure it won't always be like this)

cat $METAFILE | grep '<image type="source">' | sed "s/^\ *<[^>]*>//g;s/<\/[^>]*>//g" | cut -d'>' -f2  # For 1 screenshot
cat $METAFILE | grep '<image>' | sed "s/^\ *<[^>]*>//g;s/<\/[^>]*>//g" | cut -d '>' -f1 | head -n1 # For multiple screenshots

Benefits:

  • User see app in better resolution
  • this will simplify worker.sh

Warning:

Not all include appdata.xml or metainfo.xml in your AppImage

@probonopd
Copy link
Member

probonopd commented Jul 21, 2024

I think we already show the screenshot specified there, if one exists?

In any case, part of the test is that we can take a screenshot, and I am checking those for any obvious issues (like just a black or white window).

This test must still be passed, even though we then use the AppStream screenshot when putting together the HTML.

@Drsheppard01
Copy link
Contributor Author

Historically, most applications in Linux have an "Internet addiction" and often instead of a screenshot giving the user an idea of the application's appearance and functions, the user sees a "No Internet connection" window

@probonopd
Copy link
Member

probonopd commented Jul 21, 2024

Yes. Hence if the AppStream metadata includes a screenshot, we use that one.

But if the application just shows a black or white window, I consider that a failed test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants