Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable blocks in comments no longer available when upgrading Simple site to Atomic #39484

Open
mgozdis opened this issue Sep 22, 2024 · 9 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Comments [mu wpcom Feature] Verbum Comments Verbum, a better comment experience, app developed in the mu-wpcom plugin [Platform] Atomic [Plugin] Wpcomsh [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Type] Bug When a feature is broken and / or not performing as intended

Comments

@mgozdis
Copy link

mgozdis commented Sep 22, 2024

Impacted plugin

Jetpack

Quick summary

The Enable blocks in comments setting becomes unavailable when upgrading a Simple site to Atomic and blocks can no longer be used in comments. This creates an inconsistent user experience when upgrading. This possibly affects all current AT sites, but I am not sure. None of my test AT sites display the setting currently.

This user had various settings change when going AT, but I'm only filing a bug report related to Verbum for now: 8762683-zd-a8c

This same user also experienced an issue 2 months ago where comments did not display at all while their site was still Simple until disabling and enabling "Enable blocks in comments": p2EDhh-2iu-p2

Steps to reproduce

  1. Create a free site
  2. Ensure Enable blocks in comments is enabled by default under Settings > Discussion
  3. Upgrade to a Business plan and activate hosting features to go Atomic
  4. Check Settings > Discussion or https://wordpress.com/settings/discussion/{siteurl} and see "Enable blocks in comments" is gone with no way to enable
  5. Check comment forms on frontend and see blocks can't be used
  6. Revert the site back to Simple and see the option return, allowing blocks to be used in comments again

A clear and concise description of what you expected to happen.

Settings for comments should remain the same when upgrading a Simple site to Atomic.

What actually happened

The settings change and become unavailable.

Impact

Most (> 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

@mgozdis mgozdis added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Comments Needs triage Ticket needs to be triaged [mu wpcom Feature] Verbum Comments Verbum, a better comment experience, app developed in the mu-wpcom plugin labels Sep 22, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Platform] Atomic labels Sep 22, 2024
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 8762683-zen

@github-actions github-actions bot added [Pri] High Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". labels Sep 22, 2024
@anomiex
Copy link
Contributor

anomiex commented Sep 23, 2024

Pinging @Automattic/vertex for visibility.

@anomiex anomiex added [Plugin] Wpcomsh and removed [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Needs triage Ticket needs to be triaged labels Sep 23, 2024
@zaguiini zaguiini self-assigned this Sep 24, 2024
@zaguiini
Copy link
Contributor

@heavyweight, would you mind walking me through the necessary steps to fix this problem?

@zaguiini
Copy link
Contributor

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated
Simple Atomic
Image Image

@heavyweight
Copy link
Contributor

This is expected behaviour at the moment.
We didn't implement block support for commenting on atomic sites, that's why that option is not available.

@zaguiini
Copy link
Contributor

@heavyweight so this (fbhepr%2Skers%2Swrgcnpx%2Scebwrpgf%2Scnpxntrf%2Swrgcnpx%2Qzh%2Qjcpbz%2Sfep%2Ssrngherf%2Sireohz%2Qpbzzragf%2Snffrgf%2Spynff%2Qireohz%2Qnqzva.cuc%3Se%3Q9s212812%23114%2Q119-og) is only for Simple?

We didn't implement block support for commenting on atomic sites, that's why that option is not available.

Any particular reason? Would it be a big lift?

@heavyweight
Copy link
Contributor

@heavyweight so this (uggcf%3N%2S%2Suers.yv%2S%3Suggcf%3N%2S%2Sbcratebx.n8p.pbz%2Sfbhepr%2Skers%2Swrgcnpx%2Scebwrpgf%2Scnpxntrf%2Swrgcnpx%2Qzh%2Qjcpbz%2Sfep%2Ssrngherf%2Sireohz%2Qpbzzragf%2Snffrgf%2Spynff%2Qireohz%2Qnqzva.cuc%3Se%3Q9s212812%23114%2Q119-og) is only for Simple?

Correct

We didn't implement block support for commenting on atomic sites, that's why that option is not available.

Any particular reason? Would it be a big lift?

I think yes, it does require some work. We never got to it. If I remember correctly there were styling issues that needed fixing and maybe some other things that I can't remember at the moment.

@zaguiini
Copy link
Contributor

I think yes, it does require some work. We never got to it. If I remember correctly there were styling issues that needed fixing and maybe some other things that I can't remember at the moment.

@inaikem do you think that'd require a project?

@inaikem
Copy link

inaikem commented Sep 26, 2024

Based on @heavyweight's comment, I'd say yes 👍

@zaguiini zaguiini removed their assignment Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Comments [mu wpcom Feature] Verbum Comments Verbum, a better comment experience, app developed in the mu-wpcom plugin [Platform] Atomic [Plugin] Wpcomsh [Pri] High [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Type] Bug When a feature is broken and / or not performing as intended
Projects
Status: Projects
Development

No branches or pull requests

5 participants