Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MapsSearchClient.GetReverseGeocodingAsync(): CountryRegion.Iso is null. #46313

Closed
julien-bertolini opened this issue Sep 26, 2024 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@julien-bertolini
Copy link

Library name and version

Azure.Maps.Search 2.0.0-beta3

Describe the bug

MapsSearchClient.GetReverseGeocodingAsync() always returns null ISO country code:
image

In the RawResponse content, we can see that ISO is correct. :
image

Expected behavior

ISO Country Code should be the same as the one in the raw response content.

Actual behavior

ISO Country Code is always null.

Reproduction Steps

var geopos = new GeoPosition(0.377955, 42.807553);
var response = await _searchClient.GetReverseGeocodingAsync(geopos);
var address = response.Value.Features.FirstOrDefault()?.Properties.Address;

Environment

No response

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 26, 2024
@jsquire jsquire added Service Attention Workflow: This issue is responsible by Azure service team. Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Maps labels Sep 26, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 26, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @dubiety @jecmenicanikola.

@dubiety dubiety self-assigned this Sep 30, 2024
@dubiety
Copy link
Member

dubiety commented Sep 30, 2024

Hi @julien-bertolini ,

Thank you for reporting this issue. We're fixing this issue and will get back to you once this fix is released!

dubiety pushed a commit that referenced this issue Sep 30, 2024
* Change ISO to lowercase in AddressCountryRegion.Serialization.cs

* Use CodeGenSerialization

* Remove unnecessary using
@dubiety
Copy link
Member

dubiety commented Oct 1, 2024

Hi @julien-bertolini , It's fixed in our 2.0.0-beta.4 . I'll close this bug for now. Let us know if there's any problem. Thank you very much!

@dubiety dubiety closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Maps needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants