Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that the Step does not transition #607

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

mkht
Copy link
Contributor

@mkht mkht commented Aug 15, 2024

Description of the Change

The JS library bs-stepper is not built for Bootstrap 5, so the legacy data-target attribute should be used instead of the data-bs-target attribute.

Related Issue

This PR will fix #606

Additional Context

This bug was brought in when the migration from Bootstrap 4 to 5 was done in Pode.Web v1.0.0-preview2.

mkht and others added 2 commits August 15, 2024 14:46
The JS library bs-stepper is not built for Bootstrap 5, so the legacy data-target attribute should be used instead of the data-bs-target attribute.
@Badgerati Badgerati added this to the 1.0.0 milestone Oct 9, 2024
@Badgerati Badgerati added the bug 🐛 Something isn't working label Oct 9, 2024
Copy link
Owner

@Badgerati Badgerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Badgerati Badgerati merged commit 41d3c89 into Badgerati:develop Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steps no longer transition in v1.0.0-preview2
2 participants