Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Only example, or build config example? #4

Open
kevinmpowell opened this issue Aug 13, 2019 · 2 comments
Open

JS Only example, or build config example? #4

kevinmpowell opened this issue Aug 13, 2019 · 2 comments

Comments

@kevinmpowell
Copy link

@daniel-nagy great work on this. I really want to use it in combination with Lit Element but I'm struggling to figure out how to integrate it into my existing set of components. I'm using a very simple rollup config with only typescript and resolve plugins. But I'm getting other errors related to the @babel/plugin-proposal-class-properties plugin.

I don't want to use babel for my modern browser build if possible, but I'm unclear on how to get it all wired up.

Any thoughts or clarity you could add to the README would be helpful. Thanks!

@daniel-nagy
Copy link
Contributor

Are you importing the module for side effects?

import '@boulevard/vampire';

Rollup may be tree shaking the exports because it doesn't know that they contain side effects. Can you confirm this by looking at your rollup output and seeing if it contains any logic from this file.

I'm using a very simple rollup config with only typescript and resolve plugins. But I'm getting other errors related to the @babel/plugin-proposal-class-properties plugin.

This module wouldn't have anything to do with that, it sounds like you have some issues with your rollup config.

@kevinmpowell
Copy link
Author

kevinmpowell commented Aug 13, 2019

Are you importing the module for side effects?

Yes. My import is the same. All of the VampireRoot file exists in the compiled output.

@daniel-nagy would it be possible for you to share your compiler config? The stackblitz example in the readme seems to obscure how the code is actually being compiled.

Edit: And I'm not super familiar with Stackblitz's interface, it's possible there's a config view somewhere that I don't know how to access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants