Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Add hotkey for 'Create Pin' on current tile #82

Closed
felixakiragreen opened this issue Nov 11, 2016 · 8 comments
Closed

Add hotkey for 'Create Pin' on current tile #82

felixakiragreen opened this issue Nov 11, 2016 · 8 comments

Comments

@felixakiragreen
Copy link

felixakiragreen commented Nov 11, 2016

Right now the user workflow for adding a Pin is:

  1. Click the Pins button above the Minimap
  2. Click add new pin button
  3. Type in name
  4. Choose icon
  5. Press "enter" or done
  6. Close Pins menu

But it could be (If user has the mouse above a tile):

  1. Press hotkey (Pin menu pops up)
  2. Type in name
  3. Choose icon
  4. Press "enter" or done
@chaorace
Copy link
Member

Good idea, though, this will probably come after #64

@jacks0nX
Copy link

Usual behavior is that immediately upon entering the pin dialog a pin is created, should probably keep that behavior (as clunky as it is) in order to not rewrite the whole thing.

@felixakiragreen
Copy link
Author

@jacks0nX that sounds right.

@chaorace
Copy link
Member

@jacks0nX I guess I'll move this from low priority to future revisit, then?

@vttale
Copy link

vttale commented Nov 17, 2016

To expand on the opening comment, the existing workflow is actually somewhat worse, because it involves the step "move to tile to pin" after "click add pin". When you're doing a bunch of pins at once then you have to move back to "add pin" and then back to the next tile. It's a lot of annoying extra mousing around that could really stand to be obviated.

@jacks0nX
Copy link

Well, wouldn't what you mention be fixed with our aforementioned approach?

@vttale
Copy link

vttale commented Nov 19, 2016

Yes, I hope so, with the caveat that I'd like the hotkey to pop up not just the pin menu, but initiate the "Add Pin" function.

@jacks0nX jacks0nX self-assigned this Nov 19, 2016
jacks0nX added a commit to jacks0nX/cqui that referenced this issue Nov 19, 2016
@jacks0nX
Copy link

Note: this does not fix the known bug that when creating a new pin an old one is actually given the chosen name/icon. I forgot about this and wondered why my implementation didn't work. Really annoying though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants