Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model component IDs clash, causing unexpected behaviour #136

Open
jbudynk opened this issue Feb 6, 2017 · 0 comments
Open

model component IDs clash, causing unexpected behaviour #136

jbudynk opened this issue Feb 6, 2017 · 0 comments
Labels

Comments

@jbudynk
Copy link
Member

jbudynk commented Feb 6, 2017

Say one saves a model to a .json file, and the component IDs are m5, m6, m7, and m8. Then this person adds 5 new model components to the Fitting Tool. That last component will also be called "m5", thus wiping out the old "m5" loaded earlier.

To reproduce:

  • load pks1127-14 from NED
  • open the Fitting Tool
  • load this Json file. These components are FROZEN. Keep them frozen. Evaluate the fit from the Plotter to see what it looks like.
  • add 4 new components (powerlaws, broken powerlaws, whatever).
  • set the fitting range from gamma to far IR (~1e7 Angstroms)
  • Do a fit, for example m5 + m6 + m1 + m2, where m5 and m6 are old components, and m1/m2 are new components.
  • now add another new component. This one will be m5. Set the model expression to m5 + m6 + m1 + m5.
  • fit

You should see component 5 (in the radio part of the spectrum) has completely changed shape, if not disappeared entirely.

@jbudynk jbudynk added the bug label Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant