Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dodola regrid --cyclic into new dodola add-cyclic #110

Open
brews opened this issue Aug 4, 2021 · 2 comments
Open

Refactor dodola regrid --cyclic into new dodola add-cyclic #110

brews opened this issue Aug 4, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@brews
Copy link
Member

brews commented Aug 4, 2021

The dodola regrid --cyclic flag isn't really useful in the context of regridding because it usually requires large-scale rechunking of data before regridding. This makes the --cyclic flag useless for our purpose.

A solution to this is to put the logic for --cyclic into it's own service/CLI command.

@brews brews added the enhancement New feature or request label Aug 4, 2021
@brews brews self-assigned this Aug 4, 2021
@brews
Copy link
Member Author

brews commented Sep 3, 2021

On second thought, we have use for the "cyclic" option in the core functions when applied to a distributed regridding...

Edit: Ahhh but it still fails because adding cyclic adds chunks along the lat/lon dims...

@brews brews removed their assignment Dec 18, 2021
@brews
Copy link
Member Author

brews commented Dec 18, 2021

I'm not going to have time to handle this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant