Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_valid property to assignments? #52

Open
timwis opened this issue Oct 23, 2016 · 0 comments
Open

Add is_valid property to assignments? #52

timwis opened this issue Oct 23, 2016 · 0 comments

Comments

@timwis
Copy link
Member

timwis commented Oct 23, 2016

Pulled out of #35

Use case:

Cathy and Anna are both Deputy Finance Directors. Contracts can be approved by either of them during the "Awaiting Finance Approval" state.

@mjumbewu said:

I'm considering adding an is_valid field to Assignment instances. So, in the case where Cathy and Anna are both Deputy Finance Directors, when one acts on their assignment, the other's assignment would get is_valid set to False -- perhaps explicitly in the handler, perhaps automatically as a consequence of the case transitioning out of the assigned state with no action taken on the assignment. Probably the latter.

Does that seem reasonable? If the case transitions to another state, then all incomplete assignments are simply marked as invalid?

@timwis replied:

maybe I'm misunderstanding, but I'm not sure that's necessary. If the /cases/awaiting/ endpoint queries cases that (a) are assigned to you, (b) you haven't acted on yet, and (c) the case is currently in the state you're assigned to -- it should handle both scenarios described above, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant