Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: smoother scrolling ... #10440

Open
mmeeks opened this issue Nov 7, 2024 · 1 comment
Open

perf: smoother scrolling ... #10440

mmeeks opened this issue Nov 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request unconfirmed

Comments

@mmeeks
Copy link
Contributor

mmeeks commented Nov 7, 2024

Just wondering what's up with scrolling in writer - I load our writer sample document from make run and go to the nice big purple image which gives a good view of what's up.

Then I scroll with the touch-pad up and down - it 'feels' not entirely smooth; profile here:

image

And I wonder ;-) but need someone clueful to comment. Is it possible that:

  • touchpad has a certain typematic rate - and we get a series of 'jerks' as the display moves from the events, and we would do well to animate between them for a more fluid look.
  • there are a load of overlapping 'Animation' things - is this for the 'comments' that sit on top of the writer document and seem to move (nicely) but out of sync with the document ;-)
  • The CollectAutofillContentService.processMutations stuff from (I guess) this 'bootstrap' code - seems to take a surprising amount of time - I've seen some chunks of profile that have a millisecond of JS doing (who knows what) in 'processMutations' - is it possible that our attempts to touch the DOM / do changes at a co-ordinated time are somewhat stymied by this well hidden 'Idle' event processing ? would adding a forced processMutations at the end of some 'resumeDrawing()' method or "messagesdone" event be useful ?

Would be great to have a poke about to see if there's something up there; I fear we have some self-inflicted paper-cuts there that perhaps we could fix easily ;-)

@mmeeks
Copy link
Contributor Author

mmeeks commented Nov 7, 2024

Interestingly it seems like various overlays / sections are particularly expensive to update - it's also notable that the comment bubbles seem to wander wrt. their position vs. the document - might be nice to render them on the canvas itself somehow if that's possible (?)

image

And of course there is a chunk of low hanging waste here: that #10441 should help with the comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unconfirmed
Projects
Status: No status
Development

No branches or pull requests

2 participants