You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #97 I found that the test was failing got go1.9 or lower, but not above. I tracked this down to a failure of the set up to provide an non-empty input string because hex.DecodeString was given an odd-length string. The call to hex.DecodeString in the tests in "io_test.go" ignore the "error" returned allowing this kind of test corruption.
The text was updated successfully, but these errors were encountered:
In the big change to arrays I changed the string parse to panic on error on the basis that tests should fail very noisily if the hard-coded constants are wrong. In the PR I discovered this in, I have just fixed one of them to Fatalf if it's wrong.
In #97 I found that the test was failing got go1.9 or lower, but not above. I tracked this down to a failure of the set up to provide an non-empty input string because
hex.DecodeString
was given an odd-length string. The call tohex.DecodeString
in the tests in "io_test.go" ignore the "error" returned allowing this kind of test corruption.The text was updated successfully, but these errors were encountered: