Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile the two versions of adaptationfield.go. #106

Open
mikereedell opened this issue Nov 14, 2018 · 0 comments
Open

Reconcile the two versions of adaptationfield.go. #106

mikereedell opened this issue Nov 14, 2018 · 0 comments

Comments

@mikereedell
Copy link
Collaborator

There are two files that deal with AdaptationFields:

  • packet/adaptionfield.go: This one feels like the "right" one to use.
  • packet/adaptationfield/adaptationfield.go: This one uses the older functional style.

I propose removing the packet/adaptationfield/adaptationfield.go file in favor of packet/adaptationfield.go as long as the functionality is the same and anything that is missing from packet/adaptationfield.go is filled in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikereedell