Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension point for custom ibc port name #1710

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add extension point for custom ibc port name #1710

wants to merge 2 commits into from

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 10, 2023

🚧 early version

Resolves #1707

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #1710 (88ae8da) into main (4313d7f) will decrease coverage by 0.06%.
The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
- Coverage   57.43%   57.37%   -0.06%     
==========================================
  Files          62       62              
  Lines        8145     8158      +13     
==========================================
+ Hits         4678     4681       +3     
- Misses       3030     3039       +9     
- Partials      437      438       +1     
Files Coverage Δ
x/wasm/ibc.go 68.71% <100.00%> (ø)
x/wasm/keeper/handler_plugin.go 81.18% <100.00%> (ø)
x/wasm/keeper/handler_plugin_encoders.go 80.89% <100.00%> (ø)
x/wasm/keeper/keeper_cgo.go 94.28% <100.00%> (+0.16%) ⬆️
x/wasm/keeper/options.go 82.45% <100.00%> (+0.63%) ⬆️
x/wasm/keeper/keeper.go 79.52% <50.00%> (-0.50%) ⬇️
x/wasm/keeper/ibc.go 58.33% <40.00%> (-19.45%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBC port id creation is not compatible with Bech32 characters space
1 participant