Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the dataflow graph code #19

Open
nickzoic opened this issue May 29, 2023 · 0 comments
Open

Rewrite the dataflow graph code #19

nickzoic opened this issue May 29, 2023 · 0 comments
Labels
v0.1.x Consider post v0.1.0 release.

Comments

@nickzoic
Copy link
Collaborator

There's a not lot to like about this code:

  • Adding binding events to every label individually seems clumsy.
  • FixedUnbindMixin works but maybe we could make it unnecessary?
  • FlippyCanvas is a pretty weird thing to be split out, and should probably just be part of the behaviour of a better GraphWrapper.
  • I'm not convinced that the UI decisions here are all for the best.

This issue exists because I'm not going to think about any of these things until v0.1.x is released.
@nickzoic nickzoic added the v0.1.x Consider post v0.1.0 release. label May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v0.1.x Consider post v0.1.0 release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickzoic