Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid pipes drop brackets when waterlogged #1552

Closed
AzaSad opened this issue Jul 27, 2024 · 2 comments · May be fixed by Creators-of-Create/Create#7126
Closed

Fluid pipes drop brackets when waterlogged #1552

AzaSad opened this issue Jul 27, 2024 · 2 comments · May be fixed by Creators-of-Create/Create#7126
Labels
type: bug Issue where something isn't working type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it.

Comments

@AzaSad
Copy link

AzaSad commented Jul 27, 2024

Describe the Bug

Fluid pipes drop his brackets when waterlogged, but they are still visible in the model

Reproduction Steps

1.Place a fluid pipe
2.Place a bracket
3.Waterlog the pipe

Expected Result

The fluid pipe should keep the bracket when waterlogged, or the bracket should stop being visible when dropped

Screenshots and Videos

FluidPipeBug.mp4

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Other Mods

No response

Additional Context

i think the problem is the onStateReplaced method on the FluidPipeBlock class

exactly this part

		if (state != newState && !isMoving)
			removeBracket(world, pos, true).ifPresent(stack -> Block.dropStack(world, pos, stack));

i ask, why would it be needed, since i think the only instance in which the fluid pipe state gets replaced is when waterlogged, right?

@AzaSad AzaSad added the type: bug Issue where something isn't working label Jul 27, 2024
@AzaSad AzaSad closed this as completed Jul 27, 2024
@AzaSad AzaSad reopened this Jul 27, 2024
@AzaSad
Copy link
Author

AzaSad commented Jul 27, 2024

2024-07-27_07 48 26

Indeed changing those two lines seem to fix the issue (Sorry for closing and reopening, this is my first time submitting an issue in github)

@IThundxr IThundxr added the type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it. label Sep 30, 2024
IThundxr added a commit to IThundxr/Create that referenced this issue Nov 4, 2024
@IThundxr
Copy link
Member

IThundxr commented Nov 4, 2024

PR'd fix upstream

@IThundxr IThundxr closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issue where something isn't working type: upstream This is inherited from upstream Forge Create. It is highly unlikely we will change it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants