Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to all functions, methods? #16

Open
MNasert opened this issue May 11, 2023 · 2 comments
Open

Add typing to all functions, methods? #16

MNasert opened this issue May 11, 2023 · 2 comments
Assignees
@nfelnlp @MNasert
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@MNasert
Copy link
Member

MNasert commented May 11, 2023

No description provided.

@MNasert MNasert added documentation Improvements or additions to documentation question Further information is requested labels May 11, 2023
@MNasert
Copy link
Member Author

MNasert commented May 11, 2023

Put emphasis on all

@MNasert
Copy link
Member Author

MNasert commented May 11, 2023

I noticed inconsistent or missing typing in many functions and/or methods, reducing readability. for jit-ed functions this may also impact performance, i need to look into if typing changes the jit

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/dataloader.py#L120

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/dataloader.py#L280

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/dataloader.py#L129

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/fastcfg.py#L3

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/tools.py#L16

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/tools.py#L44

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/tools.py#L149

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/tools.py#L162

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/tools.py#L174

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/tools.py#L205

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/tools.py#L252

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/tools.py#L267

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/search_methods/fastexplain.py#L8

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/search_methods/fastexplain.py#L36

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/search_methods/fastexplain.py#L79

https://github.com/MNasert/dfki-verbalizer/blob/9baf4c4f65b1a78e68da4475128b7d78a88ca6e8/src/search_methods/fastexplain.py#L119

... the list goes on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfelnlp nfelnlp

@MNasert MNasert

Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nfelnlp @MNasert