Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing testcases for UHSLC #881

Closed
veenstrajelmer opened this issue Jul 4, 2024 · 1 comment · Fixed by #886
Closed

Failing testcases for UHSLC #881

veenstrajelmer opened this issue Jul 4, 2024 · 1 comment · Fixed by #886

Comments

@veenstrajelmer
Copy link
Collaborator

Due to null coordinate meta.geojson for station Minicoy.

FAILED tests/test_observations.py::test_ssh_catalog_subset_expected_fields[uhslc-fast] - AttributeError: 'NoneType' object has no attribute 'x'
FAILED tests/test_observations.py::test_ssh_catalog_subset_expected_fields[uhslc-rqds] - AttributeError: 'NoneType' object has no attribute 'x'
FAILED tests/test_observations.py::test_ssh_catalog_subset[uhslc-fast] - AttributeError: 'NoneType' object has no attribute 'x'
FAILED tests/test_observations.py::test_ssh_catalog_subset[uhslc-rqds] - AttributeError: 'NoneType' object has no attribute 'x'
FAILED tests/test_observations.py::test_ssh_retrieve_data[uhslc-fast] - AttributeError: 'NoneType' object has no attribute 'x'
FAILED tests/test_observations.py::test_ssh_retrieve_data[uhslc-rqds] - AttributeError: 'NoneType' object has no attribute 'x'

Emailed UHSLC on 4-7-2024 about this.

@veenstrajelmer
Copy link
Collaborator Author

veenstrajelmer commented Jul 7, 2024

geojson was fixed, however the testcases still fail with a different error:

  File C:\DATA\dfm_tools\dfm_tools\observations.py:309 in <lambda>
    time_min = uhslc_gpd[timespan_var].apply(lambda x: x["oldest"])
TypeError: string indices must be integers, not 'str'

This happens with geopandas>=1.0.0 only, there was no issue in older versions. This is reported on 7-7-2024 in geopandas/pyogrio#445.

@veenstrajelmer veenstrajelmer linked a pull request Jul 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant