Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete interactions/buttons.mdx page #60

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dlchamp
Copy link
Contributor

@dlchamp dlchamp commented Aug 15, 2023

Description

Complete the interactions/buttons page

  • Add basic View example
  • Add example for handling timeout and View.stop (disabled buttons and clear_items)
  • Move low level example to Views vs low-level section

Relevant Issues

Closes #59

- Add basic View example
- Add example for handling timeout (disabling buttons and clear_items)
- Move low level example to Views vs low-level section
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! This looks good, most of my comments are about formatting and other minor nits.

A more general comment about the entire guide's structure:
With the addition of this page, the guide starts having some redundancy between the pages for buttons and select menus, both regarding view timeouts and low-level components.
This isn't relevant to this PR directly, but we should refactor common sections into a separate page in the future.

guide/docs/interactions/buttons.mdx Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Outdated Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Outdated Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Outdated Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Outdated Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Outdated Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Outdated Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Outdated Show resolved Hide resolved
guide/docs/interactions/buttons.mdx Outdated Show resolved Hide resolved
@dlchamp
Copy link
Contributor Author

dlchamp commented Aug 27, 2023

ty! This looks good, most of my comments are about formatting and other minor nits.

A more general comment about the entire guide's structure: With the addition of this page, the guide starts having some redundancy between the pages for buttons and select menus, both regarding view timeouts and low-level components. This isn't relevant to this PR directly, but we should refactor common sections into a separate page in the future.

I was thinking the same thing as I was working on this.

dlchamp and others added 9 commits August 27, 2023 10:01
remove unnecessary "default timeout" comment

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: DLCHAMP <[email protected]>
correct View Example link

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: DLCHAMP <[email protected]>
remove unneeded comment in disabled button example

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: DLCHAMP <[email protected]>
adjust comment structure in button_view example

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: DLCHAMP <[email protected]>
remove ellipses from example

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: DLCHAMP <[email protected]>
remove unnecessary comment in timeout example

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: DLCHAMP <[email protected]>
wording in timeout example slash command

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: DLCHAMP <[email protected]>
remove unneeded custom_id check in low level example

Co-authored-by: shiftinv <[email protected]>
Signed-off-by: DLCHAMP <[email protected]>
reword comments in timeout example
remove duplicate comments from second button callback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review t: enhancement t: page/section addition Pull Request to add new content to the guide.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Complete interactions/buttons page
2 participants