Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB abstraction layer #21

Open
wavexx opened this issue Jan 3, 2015 · 5 comments
Open

DB abstraction layer #21

wavexx opened this issue Jan 3, 2015 · 5 comments

Comments

@wavexx
Copy link
Member

wavexx commented Jan 3, 2015

We need a proper DB abstraction layer that handles operations at a higher level ("add ticket", "remove grant"). A generic DB class (holding most of the shared code) and driver-specific classes are required to handle both PDO quirks (such as missing generic reconnection support) and driver-specific issues (sql differencies).

This would allow to merge the DB creation/upgrade code in a saner way, possibly removing the need of the manual database setup.

@wavexx
Copy link
Member Author

wavexx commented Jul 28, 2017

Doctribe DBAL seems to fit the bill, providing the minimal abstraction layer without pretending to be an ORM.

@jenszahner
Copy link

I've just started working on refactoring the code in my forked repo... Feel free to have a look. During refactoring I'm also refactoring the Hook calling code... I'm open for any kind of feedback.

@wavexx
Copy link
Member Author

wavexx commented Jul 16, 2018 via email

@jenszahner
Copy link

I'll finish the code with Doctrine DBAL and probably you could later on merge it into a separate branch of dl ...

@jenszahner
Copy link

I've just completed the refactoring in my forked repo... I won't fill in a pull request...
Maybe we should discuss the changes as soon as you've got some time to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants