-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DB abstraction layer #21
Comments
Doctribe DBAL seems to fit the bill, providing the minimal abstraction layer without pretending to be an ORM. |
I've just started working on refactoring the code in my forked repo... Feel free to have a look. During refactoring I'm also refactoring the Hook calling code... I'm open for any kind of feedback. |
On Mon, Jul 16 2018, Jens Zahner wrote:
I've just started working on refactoring the code in my forked repo...
Feel free to have a look. During refactoring I'm also refactoring the
Hook calling code... I'm open for any kind of feedback.
I'm really grateful for this. I didn't have time to have a look at your
code yet, but I was quite thrown back when I looked at DBAL last year. I
didn't want to pull in such a big dependency into DL.
|
I'll finish the code with Doctrine DBAL and probably you could later on merge it into a separate branch of dl ... |
I've just completed the refactoring in my forked repo... I won't fill in a pull request... |
We need a proper DB abstraction layer that handles operations at a higher level ("add ticket", "remove grant"). A generic DB class (holding most of the shared code) and driver-specific classes are required to handle both PDO quirks (such as missing generic reconnection support) and driver-specific issues (sql differencies).
This would allow to merge the DB creation/upgrade code in a saner way, possibly removing the need of the manual database setup.
The text was updated successfully, but these errors were encountered: