Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable server #117

Open
m-col opened this issue Apr 8, 2021 · 5 comments
Open

Configurable server #117

m-col opened this issue Apr 8, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@m-col
Copy link
Member

m-col commented Apr 8, 2021

It might be nice to be able to set the flask app's SERVER_NAME in the config, mainly so you can stick it on port 80 and save yourself 2 minutes each year

@celefthe celefthe added the enhancement New feature or request label Apr 8, 2021
@celefthe
Copy link
Member

celefthe commented Apr 8, 2021

Yep, I agree.

Minor point -- port 80 is privileged on Linux, which doesn't bode well with running it as a user (i.e. if the app is packaged as an executable the user runs, unless they run it with sudo which doesn't sit well with me). Would work fine Visiomode gets installed as a service that runs at login. Should keep this in mind for #41

@m-col
Copy link
Member Author

m-col commented Apr 8, 2021

port 80 is privileged on Linux

oh yeah good point, forgot about that. If this gets added at some point it might be worth adding a note in the docs on how to use port 80 without running it as root (i.e. via setcap or a firewall redirect or something).

Probs not worth the trouble though.

@github-actions
Copy link
Contributor

Stale issue message

@github-actions
Copy link
Contributor

Stale issue message

Copy link
Contributor

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants