Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS ファイルをまとめる #784

Open
seasoftjapan opened this issue Oct 23, 2023 · 0 comments
Open

CSS ファイルをまとめる #784

seasoftjapan opened this issue Oct 23, 2023 · 0 comments
Assignees
@seasoftjapan
Labels
enhancement
Milestone
2.17.3

Comments

@seasoftjapan
Copy link
Contributor

どこまでまとめるかは、検討の余地があるが、少なくとも現況のように多数に分けるメリットは薄れている。
そもそも、html/user_data/packages/default/*/import.css とかやってる時点で、分類以外にメリットあるのか謎。
むしろ、どのセレクタがどこに記述されているか不明なため grep しないといけないシーンがあり不便だった。
@seasoftjapan seasoftjapan added this to the 2.17.3 milestone Oct 23, 2023
@seasoftjapan seasoftjapan mentioned this issue Dec 20, 2023
Open
@seasoftjapan seasoftjapan self-assigned this Dec 20, 2023
seasoftjapan added a commit to seasoftjapan/eccube-2_13 that referenced this issue Dec 20, 2023
@seasoftjapan
CSS EC-CUBE#783 EC-CUBE#784 (PC)
e332637 
- CSS Nesting Module を使った実装 EC-CUBE#783
- CSS ファイルをまとめる EC-CUBE#784

```
cat \
html/user_data/packages/default/css/reset.css \
html/user_data/packages/default/css/common.css \
html/user_data/packages/default/css/contents.css \
html/user_data/packages/default/css/table.css \
html/user_data/packages/default/css/bloc.css \
html/user_data/packages/default/css/bloc_alpha.css \
html/user_data/packages/default/css/popup.css \
html/user_data/packages/default/css/print.css \
| sass-convert --indent=4 --from=css --to=scss \
> html/user_data/packages/default/style.css
```
seasoftjapan added a commit to seasoftjapan/eccube-2_13 that referenced this issue Dec 20, 2023
@seasoftjapan
CSS ファイルをまとめる EC-CUBE#784
983f622 
削除されたファイルを参照しているが未使用と思われるファイルを削除する。
ji-eunsoo added a commit that referenced this issue Feb 14, 2024
@ji-eunsoo
Merge pull request #804 from seasoftjapan/seasoft-783
4848672 
#783 #784 CSS改善 (PC)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seasoftjapan seasoftjapan

Labels
enhancement
Projects
None yet
Milestone
2.17.3
Development

No branches or pull requests
1 participant
@seasoftjapan