The add button is not disabled

[Bashamega]

Description

Hello:)

I have noticed that without entering anything in the GitHub URL placeholder the button is still clickable. It should first test against a regex to see if there is a valid GitHub URL.

Screenshots

No response

Additional information

If you are stuck and don't know the correct regex this should work:

^https:\/\/github\.com\/[a-zA-Z0-9_-]+\/[a-zA-Z0-9_-]+$

[eddiejaoude]

Thank you 👍

[PadamSinha2511]

Can you please assign this to me, I can work on this.

[eddiejaoude]

Sure assigned to you @PadamSinha2511

[PadamSinha2511]

I noticed that the compose.yaml file does not have a volume for the app to sync the local development to the container running the application should I add a volume and mount the app directory as

volumes:
- .:/usr/src/app

[eddiejaoude]

This could be the issue that @Bashamega has. @Pradumnasaraf could you let us know if this is missing or if we are we using another way to achieve this? Thank you

[Pradumnasaraf]

Hey Eddie,

Sure, @PadamSinha2511 you can add. I was going to implement the compose watch feature instead of bind mount, but realised, that many people don't have the latest version of compose and it won't work, so I didn't implement that. The issue bind mounts it that it didn't work well many times, especially with Next.js apps.

Pradam, do raise a separate PR for that.

[eddiejaoude]

Thank you @Pradumnasaraf 👍

@PadamSinha2511 please can you raise another issue for the docker compose changes

[PadamSinha2511]

Sure, here is the issue id #167