Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON not formatted anymore #1205

Open
Robadob opened this issue May 14, 2024 Discussed in #1204 · 0 comments
Open

JSON not formatted anymore #1205

Robadob opened this issue May 14, 2024 Discussed in #1204 · 0 comments
Labels

Comments

@Robadob
Copy link
Member

Robadob commented May 14, 2024

Discussed in #1204

Originally posted by bytetec May 13, 2024
Hi everyone
Since the update from FLAME GPU 2.0.0-rc to FLAME GPU 2.0.0-rc.1 the export of the logfile in JSON produces only a one liner. Does anybody else has this issue?
Before:
image
After:
image


It appears the methods of RapidJSON's Writer are not virtual, hence when a pointer to the PrettyWriter subclass is cast to Writer, method calls are not forwarded to the sub class.

writer = std::move(t_writer);

This bug was introduced when the StateWriter interface was refactored to better enable partial state writes.

Solution would probably be to template JSONStateWriter so that the two different printers have distinct objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant