Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker windows builder. #77

Open
onaclov2000 opened this issue Oct 26, 2023 · 2 comments
Open

update docker windows builder. #77

onaclov2000 opened this issue Oct 26, 2023 · 2 comments

Comments

@onaclov2000
Copy link
Contributor

Issue summary

[Put a detailed description of the issue here.]
Update batch file/docker files to map a local folder so you don't have to manually docker cp the related whl files out.

My only concerns with this is whether I can just use relative pathing, as in current directory gets mapped.

System information

  • [Operating system] windows
  • [Python version] tbd
  • [Gym Retro version] tbd
@MatPoliquin
Copy link
Collaborator

MatPoliquin commented Jun 9, 2024

I am trying to test docker/windows/Dockerfile.build but I get python not found errors. Have you ran into similar issues?

  • Windows 11 + Docker version 26.1.1, build 4cf5afa
  • latest stable-retro commit as for this writing

#21 [17/20] RUN cmake . -DBUILD_TESTS=ON -DBUILD_MANYLINUX=ON -DCMAKE_C_COMPILER_WORKS=1 -DCMAKE_CXX_COMPILER_WORKS=1 -DPYTHON_INCLUDE_DIR=/usr/include/python3.10 -DCMAKE_TOOLCHAIN_FILE=../cmake/win64.cmake
#21 0.452 -- The C compiler identification is GNU 10.0.0
#21 0.550 -- The CXX compiler identification is GNU 10.0.0
#21 0.560 -- Detecting C compiler ABI info
#21 0.602 -- Detecting C compiler ABI info - failed
#21 0.603 -- Detecting C compile features
#21 0.604 -- Detecting C compile features - done
#21 0.607 -- Detecting CXX compiler ABI info
#21 0.642 -- Detecting CXX compiler ABI info - failed
#21 0.642 -- Detecting CXX compile features
#21 0.643 -- Detecting CXX compile features - done
#21 1.106 -- Could NOT find Python (missing: Python_INCLUDE_DIRS Development.Module) (found suitable version "3.10.12", minimum required is "3")
#21 1.112 -- Found ZLIB: /usr/x86_64-w64-mingw32/lib/libz.a (found version "1.2.11")
#21 1.119 -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2")
#21 1.141 CMake Warning at CMakeLists.txt:306 (message):
#21 1.141 Could not find CapnProto, disabling search save/load
#21 1.141
#21 1.141
#21 1.143 CMake Deprecation Warning at third-party/gtest/googlemock/CMakeLists.txt:46 (cmake_minimum_required):
#21 1.143 Compatibility with CMake < 2.8.12 will be removed from a future version of
#21 1.143 CMake.
#21 1.143
#21 1.143 Update the VERSION argument value or use a ... suffix to tell
#21 1.143 CMake that the project does not need compatibility with older versions.
#21 1.143
#21 1.143
#21 1.144 CMake Deprecation Warning at third-party/gtest/googletest/CMakeLists.txt:53 (cmake_minimum_required):
#21 1.144 Compatibility with CMake < 2.8.12 will be removed from a future version of
#21 1.144 CMake.
#21 1.144
#21 1.144 Update the VERSION argument value or use a ... suffix to tell
#21 1.144 CMake that the project does not need compatibility with older versions.
#21 1.144
#21 1.144
#21 1.158 -- Found PythonInterp: /usr/bin/python3.10 (found version "3.10.12")
#21 1.161 -- Looking for pthread.h
#21 1.212 -- Looking for pthread.h - not found
#21 1.213 -- Could NOT find Threads (missing: Threads_FOUND)
#21 1.215 -- Could NOT find Threads (missing: Threads_FOUND)
#21 1.354 -- Configuring done
#21 1.355 CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
#21 1.355 Please set them or make sure they are set and tested correctly in the CMake files:
#21 1.355 _Python_INCLUDE_DIR
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googlemock
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googlemock
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googlemock
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googlemock
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googlemock
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googlemock
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googlemock
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googletest
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googletest
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googletest
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googletest
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googletest
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googletest
#21 1.355 used as include directory in directory /root/stable-retro/third-party/gtest/googletest
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355 used as include directory in directory /root/stable-retro/tests
#21 1.355
#21 1.364 CMake Error in CMakeLists.txt:
#21 1.364 Found relative path while evaluating include directories of "retro-base":
#21 1.364
#21 1.364 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.364
#21 1.364
#21 1.364
#21 1.366 CMake Error in CMakeLists.txt:
#21 1.366 Found relative path while evaluating include directories of "retro":
#21 1.366
#21 1.366 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.366
#21 1.366
#21 1.366
#21 1.368 CMake Warning (dev) in third-party/gtest/googlemock/CMakeLists.txt:
#21 1.368 Policy CMP0021 is not set: Fatal error on relative paths in
#21 1.368 INCLUDE_DIRECTORIES target property. Run "cmake --help-policy CMP0021" for
#21 1.368 policy details. Use the cmake_policy command to set the policy and
#21 1.368 suppress this warning.
#21 1.368
#21 1.368 Found relative path while evaluating include directories of "gmock":
#21 1.368
#21 1.368 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.368
#21 1.368 This warning is for project developers. Use -Wno-dev to suppress it.
#21 1.368
#21 1.369 CMake Warning (dev) in third-party/gtest/googlemock/CMakeLists.txt:
#21 1.369 Policy CMP0021 is not set: Fatal error on relative paths in
#21 1.369 INCLUDE_DIRECTORIES target property. Run "cmake --help-policy CMP0021" for
#21 1.369 policy details. Use the cmake_policy command to set the policy and
#21 1.369 suppress this warning.
#21 1.369
#21 1.369 Found relative path while evaluating include directories of "gmock_main":
#21 1.369
#21 1.369 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.369
#21 1.369 This warning is for project developers. Use -Wno-dev to suppress it.
#21 1.369
#21 1.370 CMake Warning (dev) in third-party/gtest/googletest/CMakeLists.txt:
#21 1.370 Policy CMP0021 is not set: Fatal error on relative paths in
#21 1.370 INCLUDE_DIRECTORIES target property. Run "cmake --help-policy CMP0021" for
#21 1.370 policy details. Use the cmake_policy command to set the policy and
#21 1.370 suppress this warning.
#21 1.370
#21 1.370 Found relative path while evaluating include directories of "gtest":
#21 1.370
#21 1.370 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.370
#21 1.370 This warning is for project developers. Use -Wno-dev to suppress it.
#21 1.370
#21 1.371 CMake Warning (dev) in third-party/gtest/googletest/CMakeLists.txt:
#21 1.371 Policy CMP0021 is not set: Fatal error on relative paths in
#21 1.371 INCLUDE_DIRECTORIES target property. Run "cmake --help-policy CMP0021" for
#21 1.371 policy details. Use the cmake_policy command to set the policy and
#21 1.371 suppress this warning.
#21 1.371
#21 1.371 Found relative path while evaluating include directories of "gtest_main":
#21 1.371
#21 1.371 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.371
#21 1.371 This warning is for project developers. Use -Wno-dev to suppress it.
#21 1.371
#21 1.372 CMake Error in tests/CMakeLists.txt:
#21 1.372 Found relative path while evaluating include directories of "test-data":
#21 1.372
#21 1.372 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.372
#21 1.372
#21 1.372
#21 1.373 CMake Error in tests/CMakeLists.txt:
#21 1.373 Found relative path while evaluating include directories of
#21 1.373 "test-emulator":
#21 1.373
#21 1.373 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.373
#21 1.373
#21 1.373
#21 1.374 CMake Error in tests/CMakeLists.txt:
#21 1.374 Found relative path while evaluating include directories of
#21 1.374 "test-memory-overlay":
#21 1.374
#21 1.374 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.374
#21 1.374
#21 1.374
#21 1.375 CMake Error in tests/CMakeLists.txt:
#21 1.375 Found relative path while evaluating include directories of "test-memory":
#21 1.375
#21 1.375 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.375
#21 1.375
#21 1.375
#21 1.376 CMake Error in tests/CMakeLists.txt:
#21 1.376 Found relative path while evaluating include directories of "test-script":
#21 1.376
#21 1.376 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.376
#21 1.376
#21 1.376
#21 1.376 CMake Error in tests/CMakeLists.txt:
#21 1.376 Found relative path while evaluating include directories of "test-search":
#21 1.376
#21 1.376 "_Python_INCLUDE_DIR-NOTFOUND"
#21 1.376
#21 1.376
#21 1.376
#21 1.378 -- Generating done
#21 1.380 CMake Generate step failed. Build files cannot be regenerated correctly.
#21 ERROR: process "/bin/sh -c cmake . -DBUILD_TESTS=ON -DBUILD_MANYLINUX=ON -DCMAKE_C_COMPILER_WORKS=1 -DCMAKE_CXX_COMPILER_WORKS=1 -DPYTHON_INCLUDE_DIR=/usr/include/python3.10 -DCMAKE_TOOLCHAIN_FILE=../cmake/win64.cmake" did not complete successfully: exit code: 1

[17/20] RUN cmake . -DBUILD_TESTS=ON -DBUILD_MANYLINUX=ON -DCMAKE_C_COMPILER_WORKS=1 -DCMAKE_CXX_COMPILER_WORKS=1 -DPYTHON_INCLUDE_DIR=/usr/include/python3.10 -DCMAKE_TOOLCHAIN_FILE=../cmake/win64.cmake:
1.376
1.376 CMake Error in tests/CMakeLists.txt:
1.376 Found relative path while evaluating include directories of "test-search":
1.376
1.376 "_Python_INCLUDE_DIR-NOTFOUND"
1.376
1.376
1.376
1.378 -- Generating done
1.380 CMake Generate step failed. Build files cannot be regenerated correctly.


Dockerfile.build:56

54 | RUN python3 -m pip install --upgrade pip wheel setuptools
55 |
56 | >>> RUN cmake . -DBUILD_TESTS=ON -DBUILD_MANYLINUX=ON -DCMAKE_C_COMPILER_WORKS=1 -DCMAKE_CXX_COMPILER_WORKS=1 -DPYTHON_INCLUDE_DIR=/usr/include/python3.10 -DCMAKE_TOOLCHAIN_FILE=../cmake/win64.cmake
57 |
58 | RUN python3 setup.py -q build_ext -i -j3

ERROR: failed to solve: process "/bin/sh -c cmake . -DBUILD_TESTS=ON -DBUILD_MANYLINUX=ON -DCMAKE_C_COMPILER_WORKS=1 -DCMAKE_CXX_COMPILER_WORKS=1 -DPYTHON_INCLUDE_DIR=/usr/include/python3.10 -DCMAKE_TOOLCHAIN_FILE=../cmake/win64.cmake" did not complete successfully: exit code: 1

View build details: docker-desktop://dashboard/build/default/default/bvks9svztv4k0sqj4tkk5qfga

@onaclov2000
Copy link
Contributor Author

onaclov2000 commented Jun 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants