Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable tests/004.phpt #40

Open
Jon4t4n opened this issue Dec 28, 2022 · 2 comments
Open

Fix and re-enable tests/004.phpt #40

Jon4t4n opened this issue Dec 28, 2022 · 2 comments
Assignees
@MartinKoeditz
Labels
bug Something isn't working

Comments

@Jon4t4n
Copy link
Contributor

Jon4t4n commented Dec 28, 2022

tests/004.phpt was disabled in PR #39. We want to fix this and re-enable the test.

Error:

Warning: main(): invalid statement handle  in .../tests/004.php on line 112
MartinKoeditz added a commit that referenced this issue Jan 31, 2023
@MartinKoeditz
Bugfix of issue #40. Test 004.phpt now working.
7a0a740
@MartinKoeditz MartinKoeditz self-assigned this Jan 31, 2023
@MartinKoeditz
Copy link
Collaborator

Checked. ibase_free_result doesn't set pointer correct after freeing resource. Test passes after latest code release.
See https://github.com/FirebirdSQL/php-firebird/commit/7a0a740048133abd26debc0ffe5f1652aebfdfbc

Please check it too.

@MartinKoeditz MartinKoeditz added the bug Something isn't working label Jan 31, 2023
@Jon4t4n
Copy link
Contributor Author

Jon4t4n commented Feb 4, 2023

Hi, thanks for taking a look at this.

I haven't had time to dig into this, but the proposed fix makes the test pass with release builds. However, it causes failures with debug builds.

See this CI job (Commit 7a0a740):
https://github.com/FirebirdSQL/php-firebird/actions/runs/4056103722/jobs/6980149414

@Jon4t4n Jon4t4n mentioned this issue Feb 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinKoeditz MartinKoeditz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jon4t4n @MartinKoeditz