Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and re-enable tests/bug46543.phpt #43

Open
Jon4t4n opened this issue Dec 28, 2022 · 0 comments
Open

Fix and re-enable tests/bug46543.phpt #43

Jon4t4n opened this issue Dec 28, 2022 · 0 comments

Comments

@Jon4t4n
Copy link
Contributor

Jon4t4n commented Dec 28, 2022

tests/bug46543.phpt was disabled if the PHP version is >= 8.0 in PR #39. We might want to fix and re-enable.

The test verifies that we don't leak memory if we call ibase_trans multiple times with invalid arguments. In older PHP versions, the engine emitted a warning so the script would keep running. But, in PHP 8, we get a fatal error and crash at the first call. So, maybe we don't need this test in newer PHP versions because you can't call the function with invalid arguments.

If we decide to keep this test disabled for PHP 8 and newer, please update the skip message in the test before closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant