Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: searchPseudoElements #137

Open
huberts opened this issue Jan 23, 2020 · 2 comments
Open

Feature request: searchPseudoElements #137

huberts opened this issue Jan 23, 2020 · 2 comments

Comments

@huberts
Copy link

huberts commented Jan 23, 2020

I spend some time trying to use pseudo-element syntax for FA5, something like
this from the official FA5 documentation. I did not find any solution, except for adding manually fontawesome/all.js script to my app/public folder and calling it from index.html:

<script data-search-pseudo-elements defer src="{{rootURL}}all.js"></script>

Are there any plans for enabling the feature, e.g. by conifg option searchPseudoElements?

@huberts huberts closed this as completed Jan 23, 2020
@huberts huberts reopened this Jan 23, 2020
@huberts huberts changed the title Undocumented feature: searchPseudoElements Feature request: searchPseudoElements Jan 23, 2020
@jrjohnson
Copy link
Collaborator

@huberts can you expand on why this would be needed? What it unlocks compared to the existing <FaIcon> syntax?

@huberts
Copy link
Author

huberts commented Jan 28, 2020

I have the component that allows me to dynamically render HTML table. I can customize table row <tr> with a specific CSS class, individually per row. In this way, I can change background or font for the whole row, just by defining the class. And, using the old FA4, I could even attach icons to specific <td>s, using pseudo-elements in CSS.
I read your comment 5 days ago and was trying to do it another way, with existing API. Now, I managed to overcome the problem by customizing component rendering the <td> element and putting the <FaIcon> in there.
So, maybe my request for the feature was too premature :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants