Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there anyway to exclude the js file from the bundle? #52

Open
NullVoxPopuli opened this issue Jun 26, 2018 · 7 comments
Open

Is there anyway to exclude the js file from the bundle? #52

NullVoxPopuli opened this issue Jun 26, 2018 · 7 comments

Comments

@NullVoxPopuli
Copy link
Contributor

I'm looking at broccoli-concat-analyser, and see:

image

it's in tiny text on the right. what's the js for? can I remove it somehow?

@robmadole
Copy link
Member

Are you talking about the fontawesome.js? The 7.87 KB entry?

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Jun 27, 2018 via email

@robmadole
Copy link
Member

Are you pre-rendering the icons @NullVoxPopuli ? I'm a little confused as to the question here. Aren't you using ember-fontawesome? If so then, that's just the JS that goes with it. (I feel like I'm missing something here ;)

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Jun 27, 2018

Yeah, ember-fontawesome https://gitlab.com/NullVoxPopuli/emberclear/blob/master/packages/frontend/package.json#L39

I'm both prerendering (prember) and not prerendering (non-prember pages), but I was hoping that the fa icon helper could be replaced by i tags at build time, ya know? Just so there is no runtime evaluation / rendering of the helper (so, the Js then wouldn't be required :) )

@jrjohnson
Copy link
Collaborator

@NullVoxPopuli it sounds doable to have a configuration option to only allow build time rendering and never include the component or any of the backing JS from fontawesome. I'm not volunteering mind you :)

@hoIIer
Copy link

hoIIer commented Apr 11, 2020

any movement on this?

@jrjohnson
Copy link
Collaborator

@burritoIand not yet. If you're interested in getting involved and helping jump into #e-fontawesome in discord and let's chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants