Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacking doesn't work #54

Open
gossi opened this issue Jun 30, 2018 · 3 comments
Open

Stacking doesn't work #54

gossi opened this issue Jun 30, 2018 · 3 comments

Comments

@gossi
Copy link

gossi commented Jun 30, 2018

stack classes class="fa-stack-2x" will get filtered in getClasses() method. Adding a stack argument is the nicest thing to fix this 😄

@robmadole
Copy link
Member

Stacking has been replaced with layers in the SVG implementation. Would this work for you?

@maxymczech
Copy link

It seems stacking is a feature still present in FontAwesome 5:

https://fontawesome.com/how-to-use/on-the-web/styling/stacking-icons

Would it kill you to just add {{#fa-stack}} component in your distribution?

@robmadole
Copy link
Member

@dantistus no it wouldn't kill us. But we think that layers is an upgrade and works much better than stacks. You can still use those classes and markup if you like; there is nothing preventing you from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants