You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I was hunting a console error for the rotation custom property validator failing for a good hour, just to find out, that the accepted value is not of a single type, but of two.
Invalid prop: custom validator check failed for prop "rotation"
being a problem with the value, but the type.
Describe alternatives you've considered
Just add 0 as valid value here.
Well, you could as well extend the validator to output the actual value and show the valid and accepted values in comparison. This would improve the developing experience by a good bit for all cases, reduce support requests and SO threads.
Thanks in advance!
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
I was hunting a console
error
for therotation
custom property validator failing for a good hour, just to find out, that the accepted value is not of a single type, but of two.String
Number
{Number | null}
).Related
Describe the solution you'd like
It would be more obvious to accept
0
as proper and valid value than suggesting to usenull
instead.The docs mention that nowhere and even if: No one would imagine
being a problem with the value, but the type.
Describe alternatives you've considered
Just add
0
as valid value here.Well, you could as well extend the validator to output the actual value and show the valid and accepted values in comparison. This would improve the developing experience by a good bit for all cases, reduce support requests and SO threads.
Thanks in advance!
The text was updated successfully, but these errors were encountered: