Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] In-band handling of cellular_comm_interface errors #118

Open
tpecar-ltek opened this issue Nov 23, 2022 · 1 comment
Open
Assignees
Labels
enhancement New feature or request feature request

Comments

@tpecar-ltek
Copy link

The cellular_comm_interface, which handles low level transfers between the modem and the cellular library, has provisions to report errors on receive / transmit (ie. caused by buffer overruns, etc.)

However, the pktio layer currently disregards this status information

( void ) pContext->pCommIntf->recv( pContext->hPktioCommIntf, ( uint8_t * ) pRead,
bufferEmptyLength,
CELLULAR_COMM_IF_RECV_TIMEOUT_MS, &bytesRead );

( void ) pContext->pCommIntf->send( pContext->hPktioCommIntf,
( const uint8_t * ) &pContext->pktioSendBuf, newCmdLen,
CELLULAR_COMM_IF_SEND_TIMEOUT_MS, &sentLen );

It would be beneficial if the errors on the low-level layer could be propagated back to the user API.

@paulbartell
Copy link
Contributor

paulbartell commented Nov 24, 2022

Hello @tpecar-ltek. I've applied the feature request tag to this request and forwarded it to the cellular library team.

We will need to map from the CellularCommInterfaceError_t type to the CellularError_t type. Feel free to do so and open a pull request if you would like. Otherwise we will prioritize your request and add it to a future release.

@chinglee-iot chinglee-iot self-assigned this Nov 24, 2022
@tpecar-ltek tpecar-ltek changed the title [Enchancement] In-band handling of cellular_comm_interface errors [Feature Request] In-band handling of cellular_comm_interface errors Dec 28, 2022
@paulbartell paulbartell added the enhancement New feature or request label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
None yet
Development

No branches or pull requests

3 participants