Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escort Service ability problematic [bounty: 16 XTR] #2582

Closed
DreadKnight opened this issue May 21, 2024 · 7 comments
Closed

Escort Service ability problematic [bounty: 16 XTR] #2582

DreadKnight opened this issue May 21, 2024 · 7 comments
Assignees
Labels
abilities The issue is related to an unit ability or more bounty Some amount of our token, XatteR, is offered coding This issue requires some programming input Deals with hotkeys, interaction & accessibility priority This should get fixed as soon as possible!
Milestone

Comments

@DreadKnight
Copy link
Member

DreadKnight commented May 21, 2024

Scavenger's Escort Service is problematic, most of the time seems to be unusable with medium or large units (upgraded).
Ability shows up as usable but you can't target hexagons for new location. This is a follow-up for the partial fix here: #2563

@DreadKnight DreadKnight added coding This issue requires some programming abilities The issue is related to an unit ability or more priority This should get fixed as soon as possible! bounty Some amount of our token, XatteR, is offered labels May 21, 2024
@DreadKnight DreadKnight added this to the 0.5 - Chimera milestone May 21, 2024
@DreadKnight DreadKnight added the input Deals with hotkeys, interaction & accessibility label May 21, 2024
@nohaibogdan1
Copy link
Contributor

@DreadKnight Can you assign it to me ?

@DreadKnight
Copy link
Member Author

@nohaibogdan1 Alright. 2 weeks soft deadline 🐻

@nohaibogdan1
Copy link
Contributor

nohaibogdan1 commented Aug 23, 2024

@DreadKnight What are the rules for the escort service ?

Lets take the situation where Scavenger has target in front

From what I observed the escort service is working in the a way that the minimum backward move is the number of hexes equal to the sum of the units sizes.

I am thinking the actual behaviour should be that minimum backwards move is one hex.

Depending on deciding this I have to either fix the require function or query function of the escort service ability.

@DreadKnight
Copy link
Member Author

@nohaibogdan1 Hmm, if going for minimum movement of one hex, it might make previewing new location a tad more awkward and eventually animation, not sure. Anyway, feel free to make a PR like that and we could take it from there, testing things in practice and adjusting stuff if something feels off.

@nohaibogdan1
Copy link
Contributor

@DreadKnight You are right. Let's go with the easier choice for the moment which is to fix the availability of the escort service (the button). Changing the way the escort service works implies a lot of work and I prefer to use my time in getting higher priority work done.

@DreadKnight
Copy link
Member Author

@DreadKnight You are right. Let's go with the easier choice for the moment which is to fix the availability of the escort service (the button). Changing the way the escort service works implies a lot of work and I prefer to use my time in getting higher priority work done.

Will probably open new issues soon and have the ability more fine grained eventually, like you said, while also tackling the X-Ray feature in another issue regarding situations like these in order to not cause confusion. Anyway, one step at a time.

@DreadKnight
Copy link
Member Author

@nohaibogdan1 I've opened issues #2616 and #2617, up for the taking, with XatteR bounties, as usual 🪙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abilities The issue is related to an unit ability or more bounty Some amount of our token, XatteR, is offered coding This issue requires some programming input Deals with hotkeys, interaction & accessibility priority This should get fixed as soon as possible!
Projects
None yet
Development

No branches or pull requests

2 participants