Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SpycYAMLParser #755

Open
PKuhlmay opened this issue Mar 29, 2024 · 1 comment · Fixed by #772
Open

Remove SpycYAMLParser #755

PKuhlmay opened this issue Mar 29, 2024 · 1 comment · Fixed by #772

Comments

@PKuhlmay
Copy link
Collaborator

It seems that the SpycYAMLParser is only used in one line:

return SpycYAMLParser::YAMLLoadString(file_get_contents($settingsFile));

We have to consider if we can remove the whole SpycYAMLParser.php file and adjust this line of code to use the TYPO3YamlFileLoader from TYPO3 or from Symfony.

This results into less code to maintain.

Also the tests needs to be adjusted then.

@PKuhlmay
Copy link
Collaborator Author

https://symfony.com/doc/current/components/yaml.html#reading-yaml-files

DavidBruchmann added a commit to DavidBruchmann/extension_builder that referenced this issue Apr 5, 2024
PKuhlmay pushed a commit to DavidBruchmann/extension_builder that referenced this issue Apr 5, 2024
PKuhlmay pushed a commit to DavidBruchmann/extension_builder that referenced this issue Apr 5, 2024
PKuhlmay pushed a commit that referenced this issue Apr 8, 2024
replace SpycYAMLParser with Symfony Yaml parser, fix #755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant