Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] One command to fix them all #1409

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[FEATURE] One command to fix them all #1409

wants to merge 4 commits into from

Conversation

Starkmann
Copy link
Collaborator

@Starkmann Starkmann commented Jul 31, 2024 •
edited by oliverklee
Loading

Fixes #1386

@Starkmann Starkmann added this to the 4.0.0: Breaking changes milestone Jul 31, 2024
@Starkmann Starkmann self-assigned this Jul 31, 2024
@coveralls
Copy link

coveralls commented Jul 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10905545286

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 10903721040: 0.0%
Covered Lines: 67
Relevant Lines: 67
💛 - Coveralls

oliverklee
oliverklee requested changes Jul 31, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
Build/Scripts/runTests.sh Show resolved Hide resolved
Build/Scripts/runTests.sh Outdated Show resolved Hide resolved
Build/Scripts/runTests.sh Show resolved Hide resolved
oliverklee

This comment was marked as resolved.

Sign in to view

@oliverklee oliverklee force-pushed the feature/runAllCodeFixes branch 3 times, most recently from f39a8a9 to 298ac5d Compare September 17, 2024 12:00
lukaszuznanski
lukaszuznanski approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@lukaszuznanski lukaszuznanski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally. Should we also mention that command in documentation in Running.rst? @oliverklee

@oliverklee
Copy link
Contributor

Should we also mention that command in documentation in Running.rst?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

@lukaszuznanski lukaszuznanski Awaiting requested review from lukaszuznanski

Assignees

@Starkmann Starkmann

Labels
runTests.sh
Projects
Best Practices Sprint
Status: In Review
Milestone
4.0.0: Breaking changes
Development

Successfully merging this pull request may close these issues.

Add a fix Composer script and runTests.sh command
4 participants
@Starkmann @coveralls @oliverklee @lukaszuznanski