Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Vocal Resync on Inst-Only Mod songs #3856

Open
2 tasks done
sphis-Sinco opened this issue Nov 13, 2024 · 6 comments
Open
2 tasks done

Bug Report: Vocal Resync on Inst-Only Mod songs #3856

sphis-Sinco opened this issue Nov 13, 2024 · 6 comments
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.

Comments

@sphis-Sinco
Copy link

sphis-Sinco commented Nov 13, 2024

Issue Checklist

  • I have properly named my issue
  • I have checked the Issues/Discussions pages to see if my issue has already been reported

Platform

Itch.io (Downloadable Build) - Windows

Browser

None

Version

0.5.3

Description (include any images, videos, errors, or crash logs)

When playing modded songs the game keeps registering that the vocals need resync even when the song doesn't even have vocals, this causes notes to jump or stay for longer and causes the Instrumental to keep jumping to different positions in the track.

The only way around this issue is playing the song in the Chart Editor by loading the .fnfc file because the vocals need to be there otherwise loading it from the "load from song" section crashes the game.

I have a video with this issue here

Steps to Reproduce

  1. Make or download a mod with an instrumental only song
  2. Play the song from Freeplay
  3. Notice the instrumental cutting and jumping to different positions in the song
@sphis-Sinco sphis-Sinco added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. labels Nov 13, 2024
@AbnormalPoof
Copy link
Contributor

Can't reproduce. I'm not sure how this bug would even occur since resyncVocals() returns if the Vocals don't exist.

@sphis-Sinco
Copy link
Author

sphis-Sinco commented Nov 13, 2024

Can't reproduce. I'm not sure how this bug would even occur since resyncVocals() returns if the Vocals don't exist.

I have a video with the issue here

@sphis-Sinco
Copy link
Author

Can't reproduce. I'm not sure how this bug would even occur since resyncVocals() returns if the Vocals don't exist.

Also when I run the game in terminal I see this traced in the logs

image

@KoloInDaCrib
Copy link
Contributor

Can't reproduce. I'm not sure how this bug would even occur since resyncVocals() returns if the Vocals don't exist.

That only checks if the VoicesGroup itself is null, not whether or not the voices within it are existent or not. I'm guessing the bug happens since when you have no voices in the group itself the time doesn't update (since it doesn't have what to update lol)

Also I was able to repro this by simply removing all the voice files (there are a LOT of checks for the voice file good god eric)

@sphis-Sinco sphis-Sinco changed the title Bug Report: Vocal Resync on Inst-only songs Bug Report: Vocal Resync on Mod songs Nov 14, 2024
@sphis-Sinco
Copy link
Author

turns out this just happens to Modded songs in general

@sphis-Sinco
Copy link
Author

nvm

@sphis-Sinco sphis-Sinco changed the title Bug Report: Vocal Resync on Mod songs Bug Report: Vocal Resync on Inst-Only Mod songs Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue.
Projects
None yet
Development

No branches or pull requests

3 participants