Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set remoteIp to client-ip rather than proxy ip #12

Open
travi opened this issue Jan 31, 2019 · 0 comments
Open

set remoteIp to client-ip rather than proxy ip #12

travi opened this issue Jan 31, 2019 · 0 comments

Comments

@travi
Copy link
Contributor

travi commented Jan 31, 2019

the event from good provides the remoteAddress from hapi, but does not account for reverse-proxies. google provides the X-Forwarded-For header, which should allow us to determine the actual client ip.

worth considering request-ip or similar libraries, using the headers for the good event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@travi