Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage typescript to add better verification of our log shape #42

Open
trevtrich opened this issue Jan 31, 2020 · 1 comment
Open

Leverage typescript to add better verification of our log shape #42

trevtrich opened this issue Jan 31, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@trevtrich
Copy link
Member

google publishes their types with the @google-cloud/logging-bunyan library. the types defined in @google-cloud/logging-bunyan/build/src/types/core.d.ts under BunyanLogRecord should help us avoid accidental shape mistakes like we've had happen twice before (i.e., for Error & URL) that break our logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trevtrich