Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max-conditional-depth #19

Open
Glavin001 opened this issue Sep 13, 2017 · 1 comment
Open

max-conditional-depth #19

Glavin001 opened this issue Sep 13, 2017 · 1 comment
Assignees
@Glavin001
Labels
good first issue rule

Comments

@Glavin001
Copy link
Owner

For example:

variable = condition1 ? ifTrueDoThis : (condition2 ? ifTrueDoThis : (condition3 ? ifTrueDoThis : ifFalseDoThis));

and

variable = condition1 && condition2 ? ifTrueDoThis : (condition3 || condition4 ? ifTrueDoThis : (condition5 && condition6 ? ifTrueDoThis : ifFalseDoThis));

These are too long and too deep. Let's limit the depth!
@Glavin001 Glavin001 added the rule label Sep 13, 2017
@Glavin001 Glavin001 self-assigned this Sep 13, 2017
@Glavin001
Copy link
Owner Author

Related to https://refactoring.guru/decompose-conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Glavin001 Glavin001

Labels
good first issue rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Glavin001