New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace references to `user_json` for clarity #161

Closed

AndreaSanchezTapia opened this issue Jul 12, 2024 · 0 comments

Member

AndreaSanchezTapia commented Jul 12, 2024 •

edited

Loading

Hi. Hope you don't mind me jumping in, but I had a thought about argument naming! I notice in the latest version of gfwr, get_raster() has had some changes, one of which is that the user specified region should be an sf object (great enhancement, thanks!). Given this change, wouldn't it make sense to use region_source = "user_polygon", or something similar, rather than "user_json"?

Originally posted by @jflowernet in #146 (comment)

The text was updated successfully, but these errors were encountered:

AndreaSanchezTapia mentioned this issue

Merged

AndreaSanchezTapia closed this as completed in

d9e9630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment