Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make objmc support at least 1 shader for high-quality rendering :) #52

Open
KriperoNio opened this issue Nov 23, 2023 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@KriperoNio
Copy link

Hello, if you don't want to do mods support, then please do shader support)
Especially vanilla. You are welcome.
For example a shader https://github.com/bradleyq/mc_vanilla_shaders

@KriperoNio
Copy link
Author

KriperoNio commented Nov 23, 2023

Moreover, you can create support for what you are already working with, because it is a texture package with a core in which you can improve your mechanics and so on.

or I don't understand something a little))

@Godlander
Copy link
Owner

because shaders don't merge, you will have to edit the shaders to do what both of them do

there is no "support" other than just writing a shader that does both.

@KriperoNio
Copy link
Author

then there will be no shader support at all?

@MrGazdag
Copy link

MrGazdag commented Dec 6, 2023

then there will be no shader support at all?

as @Godlander said, it is impossible to "add support" to another core shader automatically, you have to combine the shaders manually. Some packs make this easier than others, but it is impossible to automate this, and making support for individual packs is outside of the scope of this project

@vadim-soude
Copy link

vadim-soude commented Dec 6, 2023

I wanted to do it with this vanilla shader for a long time, can't tell when i will get the time (and if i achive to make it work at all) but if i do, i may post a link to the repo here, and i will try my best to keep as up-to-date as possible with objmc.

@Godlander
Copy link
Owner

for what its worth, i have tried to make objmc as painless as i could to merge with other shaders by using includes.

as long as uniforms and variables are set up and named accordingly it shouldn't be too difficult

@Godlander Godlander added the enhancement New feature or request label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants