Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting checks report errors in CI #212

Closed
Malcolmnixon opened this issue Oct 1, 2024 · 3 comments
Closed

Formatting checks report errors in CI #212

Malcolmnixon opened this issue Oct 1, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Malcolmnixon
Copy link
Contributor

The Static Checks action for checking format is generating a stream of clang-format parse errors:

YAML:15:18: error: invalid boolean
AlignOperands:   DontAlign
                 ^~~~~~~~~
Error reading /home/runner/work/godot_openxr_vendors/godot_openxr_vendors/.clang-format: Invalid argument
YAML:1[5](https://github.com/Malcolmnixon/godot_openxr_vendors/actions/runs/11118011256/job/30890912770#step:5:6):18: error: invalid boolean
AlignOperands:   DontAlign
                 ^~~~~~~~~
Error reading /home/runner/work/godot_openxr_vendors/godot_openxr_vendors/.clang-format: Invalid argument
YAML:15:1[8](https://github.com/Malcolmnixon/godot_openxr_vendors/actions/runs/11118011256/job/30890912770#step:5:9): error: invalid boolean
AlignOperands:   DontAlign
                 ^~~~~~~~~

The reason appears to be the .clang-format AlignOperands: DontAlign which I believe should be AlignOperands: false

@Malcolmnixon
Copy link
Contributor Author

@devloglogan Could you look into this as I believe you checked in the initial clang-format file with this option.

@Malcolmnixon
Copy link
Contributor Author

Found it - the clang-format file is virtually identical to the godot main repo (so we can follow a similar coding convention) however the godot static-checks job runs on Ubuntu 22.04 and we're running on Ubuntu 20.04. These releases of Ubuntu have wildly different versions of clang-format and the configuration files are incompatible.

We need to update the static-checks job to 22.04 and then fix coding violations that have crept in.

@Malcolmnixon Malcolmnixon added the bug Something isn't working label Oct 2, 2024
@devloglogan
Copy link
Collaborator

Fixed by #214!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants