Skip to content
This repository has been archived by the owner on Aug 21, 2020. It is now read-only.

The api should now require authentication to read data from it. #35

Open
patt0 opened this issue Dec 20, 2016 · 4 comments
Open

The api should now require authentication to read data from it. #35

patt0 opened this issue Dec 20, 2016 · 4 comments
Assignees

Comments

@patt0
Copy link
Contributor

patt0 commented Dec 20, 2016

  • Change the API
  • Change the scripts / spreadsheets that read the data
    -- Daily Dumps
    -- Master Updates

This will have implication on the app and we need to coordinate @justinribeiro so your data binding fails when you load read-only data.

@patt0 patt0 self-assigned this Dec 20, 2016
@patt0
Copy link
Contributor Author

patt0 commented Dec 20, 2016

@Scarygami should we move to POST and pass the api_key in a payload or stay with GET and use a url parameter?

@justinribeiro
Copy link
Member

On the web side, we could simply add the authorization: Bearer to the currently non-auth'ed requests much like we do with the create/edit methods. The change is minimal there, but I worry about the rest of the tooling.

@keyboardsurfer
Copy link

Any update on this?

@patt0
Copy link
Contributor Author

patt0 commented Sep 18, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants