Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile with Java 17 - drop Java 8, Java 11 #1548

Open
Anthony01M opened this issue Jun 18, 2024 · 7 comments · May be fixed by #1735
Open

Compile with Java 17 - drop Java 8, Java 11 #1548

Anthony01M opened this issue Jun 18, 2024 · 7 comments · May be fixed by #1735
Labels
enhancement New feature or request

Comments

@Anthony01M
Copy link
Contributor

Feature description

As of the latest versions of ViaVersion, Java 17 has been required to run Via.
I've tested things out to verify their claim in regards of 1.8 running on java 17 and I can confirm this works (what I used was: paper 1.8, pandaspigot 1.8 - recommended to use over paper).
I believe there's no need for us to support Java 8, Java 11 and only Java 17 and higher as of the next versions of Grim.
ViaVersion latest release: https://github.com/ViaVersion/ViaVersion/releases/tag/5.0.0

@Anthony01M Anthony01M added the enhancement New feature or request label Jun 18, 2024
@SamB440
Copy link
Collaborator

SamB440 commented Jun 18, 2024

I just know people are going to complain if we drop Java 8, but I think it's worth it

Edit: I went on Via Discord and saw someone complaining immediately

@Anthony01M
Copy link
Contributor Author

I just know people are going to complain if we drop Java 8, but I think it's worth it

Edit: I went on Via Discord and saw someone complaining immediately

Not like it's going to be reverted back, they can use old version without updates or fixes, I think it's worth it; or they could just update to a 1.8 version that supports java 17 like I did for my minigame servers.

@SamB440 SamB440 pinned this issue Jun 18, 2024
@FirephoenixX02
Copy link

I just know people are going to complain if we drop Java 8, but I think it's worth it

Edit: I went on Via Discord and saw someone complaining immediately

Not like it's going to be reverted back, they can use old version without updates or fixes, I think it's worth it; or they could just update to a 1.8 version that supports java 17 like I did for my minigame servers.

Yeah I agree everyone should update their 1.8 servers to a fork which supports Java 17. I don't see a reason to not to, as basically all 1.8 servers are minigames/pvp servers, so Vanilla functionality doesn't really matter.

@rafi67000
Copy link

definitely you should update to at least java 17.

@SamB440
Copy link
Collaborator

SamB440 commented Jul 19, 2024

My current plan is to warn about Java 17 migration in the next 1-2 updates, then actually upgrade after that.

Currently, 676 servers are below our target version: https://bstats.org/plugin/bukkit/Grim/12820#javaVersion

276 of those are on Java 16, which should be an easy bump.

@Anthony01M
Copy link
Contributor Author

Anthony01M commented Jul 21, 2024

My current plan is to warn about Java 17 migration in the next 1-2 updates, then actually upgrade after that.

Currently, 676 servers are below our target version: https://bstats.org/plugin/bukkit/Grim/12820#javaVersion

276 of those are on Java 16, which should be an easy bump.

nvm, just noticed you actually added it.

@SamB440
Copy link
Collaborator

SamB440 commented Sep 18, 2024

90.1% of servers are on Java 17+, this version will require java 17+

@SamB440 SamB440 linked a pull request Sep 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants